Skip to content

Commit

Permalink
Removes server_port from request_info
Browse files Browse the repository at this point in the history
server_port has been deprecated by python3-saml, see: SAML-Toolkits/python3-saml#276

If the server application is running behind a load balancer or a reverse proxy the request port might not match the SAML configuration.

This will resolve issue #609 - #609
  • Loading branch information
Holger Selover-Stephan authored and nijel committed Mar 3, 2022
1 parent 0fccfde commit 32d7bcf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion social_core/backends/saml.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ def _create_saml_auth(self, idp):
'https': 'on' if self.strategy.request_is_secure() else 'off',
'http_host': self.strategy.request_host(),
'script_name': self.strategy.request_path(),
'server_port': self.strategy.request_port(),
'get_data': self.strategy.request_get(),
'post_data': self.strategy.request_post(),
}
Expand Down

0 comments on commit 32d7bcf

Please sign in to comment.