-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128277: use relaxed atomics for sock_fd
#128304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after the brief look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's worth doing these sorts of changes for file descriptors. We still have unfixable race conditions when sockets are closed concurrently (see #121544)
The PR is fairly straightforward, so it's fine with me if you want to merge it. I just don't think we should bother with this sort of thing in the future. |
I see, I did this just for asyncio because tsan was complaining while running the existing test suite and this fixes all of this AFAICS. If we aren't planning to fix this maybe we should add some tsan suppressions for these for the time being? |
|
socket
module thread safe #128277