Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections #128455

Merged
merged 2 commits into from
Jan 5, 2025
Merged

gh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections #128455

merged 2 commits into from
Jan 5, 2025

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 3, 2025 •
edited by bedevere-app bot
Loading

Adds a common flags variable that is used for both instrument and apply steps. Adds -update-debug-sections to the instrument step to resolve the BOLT warning.

This patch was originally authored by @indygreg as part of astral-sh/python-build-standalone#463

I dropped some additions to BOLT_COMMON_FLAGS, but will add them in a subsequent pull request.

Closes #128437

@zanieb @indygreg
Add BOLT_COMMON_FLAGS with -update-debug-sections
88eef21 
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Jan 3, 2025
Closed
@zanieb
Copy link
Contributor Author

zanieb commented Jan 3, 2025

I don't believe this needs a news entry.

@zanieb zanieb mentioned this pull request Jan 4, 2025
Open
@zanieb
Copy link
Contributor Author

zanieb commented Jan 4, 2025

As mentioned, the BOLT_COMMON_FLAGS will be subsequently used to fix #128472, e.g., zanieb@5448cd9

corona10
corona10 approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit b60044b into python:main Jan 5, 2025
43 checks passed
@zanieb zanieb added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 5, 2025
@miss-islington-app
Copy link

Thanks @zanieb for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @zanieb for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2025
@zanieb @indygreg @miss-islington
pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (
312b99a 
pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2025
@zanieb @indygreg @miss-islington
pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (
2eb9a8d 
pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 5, 2025

GH-128512 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 5, 2025

GH-128513 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 5, 2025
@zanieb zanieb mentioned this pull request Jan 5, 2025
Open
corona10 pushed a commit that referenced this pull request Jan 5, 2025
@miss-islington @zanieb @indygreg
[3.13] gh-128437: Add BOLT_COMMON_FLAGS with `-update-debug-section…
40fd466 
…s` (gh-128455) (gh-128512)

gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
corona10 pushed a commit that referenced this pull request Jan 5, 2025
@miss-islington @zanieb @indygreg
[3.12] gh-128437: Add BOLT_COMMON_FLAGS with `-update-debug-section…
90535fe 
…s` (gh-128455) (gh-128513)

gh-128437: Add `BOLT_COMMON_FLAGS` with `-update-debug-sections` (gh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

(cherry picked from commit b60044b)

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
@zanieb @indygreg @srinivasreddy
pythongh-128437: Add BOLT_COMMON_FLAGS with -update-debug-sections (
7f767cd 
pythongh-128455)

Add `BOLT_COMMON_FLAGS` with `-update-debug-sections`

Co-authored-by: Gregory Szorc <gregory.szorc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

@corona10 corona10

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bolt instrumentation missing -update-debug-sections
3 participants
@zanieb @corona10 @erlend-aasland