Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… #128465

Merged
merged 1 commit into from
Jan 4, 2025
Merged

[3.13] gh-128354: Consistently use LIBS over LDFLAGS in library build… #128465

merged 1 commit into from
Jan 4, 2025

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 4, 2025 •
edited by bedevere-app bot
Loading

… checks (GH-128359)

(cherry picked from commit b75ed95)

ref #128359

@zanieb
[3.13] pythongh-128354: Consistently use LIBS over LDFLAGS in library…
f6b30a5 
… build checks (pythonGH-128359)

(cherry picked from commit b75ed95)

Co-authored-by: Zanie Blue <contact@zanie.dev>
@bedevere-app bedevere-app bot mentioned this pull request Jan 4, 2025
Open
@bedevere-app bedevere-app bot mentioned this pull request Jan 4, 2025
Merged
@zanieb
Copy link
Contributor Author

zanieb commented Jan 4, 2025

cc @erlend-aasland the conflict was trivial, so 🤷‍♀️

@erlend-aasland erlend-aasland enabled auto-merge (squash) January 4, 2025 00:29
@zanieb
Copy link
Contributor Author

zanieb commented Jan 4, 2025

And now I know how to use cherry_picker, that's kind of fun.

@erlend-aasland erlend-aasland merged commit 855af3b into python:3.13 Jan 4, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @erlend-aasland