-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate library/asyncio-eventloop.po #695
Conversation
有一些比較明顯需要修正的地方,以下修正完畢後我再 assign reviewers 來看暢通性和語意正確性
|
Review 到 line 548 |
原本 |
目前看下來是沒什麼大問題,一個小小的 concern 是,reST 語法中的保留空白,是否可以 其他小修正也改好的話我覺得就可以進了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cschan1828 因有更新,可能要再麻煩你 approved 一次 |
@xchux 要麻煩你直接修正這點;過去有數個 comments 也沒改到,請檢查所有 unresolved comments,其他的再請等我做 final review, thanks! |
已修正,再麻煩 @mattwang44 review |
依舊被漏掉了,我把沒改到的 comments 都整理在這邊,希望再幫忙修正,感謝~ |
已修正,再麻煩 @mattwang44 review |
#578