Fix #13881: Add plugin to disallow bytearray as filename in compile()#14173
Open
vidhyavijayan3 wants to merge 3 commits intopython:mainfrom
Open
Fix #13881: Add plugin to disallow bytearray as filename in compile()#14173vidhyavijayan3 wants to merge 3 commits intopython:mainfrom
vidhyavijayan3 wants to merge 3 commits intopython:mainfrom
Conversation
Collaborator
|
Please note that typeshed only provides type annotations, we don't need or want any custom mypy plugins – that would be detrimental to typeshed's purpose. To solve #13881, we just need to change the type annotations for |
Contributor
Author
|
Thank you for the clarification! I'll remove the custom mypy plugin and instead update the type annotation for the filename parameter in the compile() stub to use StrOrBytesPath, as suggested. Appreciate your feedback and guidance on aligning with typeshed's goals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.12 and later, passing a bytearray as the
filenameargument tocompile()is no longer allowed. This commit adds a mypy plugin that checksfor this specific misuse and emits an appropriate error message.
The plugin is applied conditionally via mypy.ini and is compatible with the
existing stubs for
compile()in builtins.pyi.This prevents false positives and ensures correct typing behavior in
accordance with the updated CPython semantics.
Closes #13881