-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Improve SpriteList doc #1620
Draft
pushfoo
wants to merge
15
commits into
pythonarcade:development
Choose a base branch
from
pushfoo:improve_spritelist_doc
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+671
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
force-pushed
the
improve_spritelist_doc
branch
3 times, most recently
from
March 9, 2023 05:00
5ceed89
to
cadb65a
Compare
This is blocked by #1639 and will need to be rebased on it |
pushfoo
force-pushed
the
improve_spritelist_doc
branch
from
March 29, 2023 03:14
ff3b24a
to
fedbcc0
Compare
Might want to consider future PRs to be smaller. Easier to review for us, quicker to get in, less risk of wasted work. |
pushfoo
force-pushed
the
improve_spritelist_doc
branch
from
April 4, 2023 23:20
ecc6ba8
to
b3d8e52
Compare
Definitely. This PR and #1639 both snowballed into much larger PRs due to being trial runs for concepts which will be applied elsewhere in the codebase. |
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My current intent is to split this into multiple smaller PRs. This one will end up being the
SpriteList
docstring rewrite.The others: