"Fix" password blinking but break alignment and efficiency #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
changed the title
pushfoo
force-pushed
the
proof-of-concept-password-fix
branch
from
714a48e
to
80fbc11
Compare
pushfoo
force-pushed
the
proof-of-concept-password-fix
branch
from
80fbc11
to
b06323c
Compare
|
I think we can drop this one, the blinking is already fixed, it was an issue with triggered rendering even when no changes where applied. |
|
Superceded by #2330. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Prove it's something to do with layout / double-render trigger in the ugliest way possible. :D
EDIT: this breaks the universe in a slightly different way. Editing the username now shows a cursor in both?
"Fix" #2120 by:
draw_text+Surface.activatecontext manager to render badly over the surfaceAnyone who wants to commit / PR into / replace this branch is welcome to.