Encapsulate relative position logic in UITextInput.on_event #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pushfoo
commented
Jul 29, 2024
pushfoo
commented
- Add relative position helpers
- Use position helpers to clean up UITextInput.on_event
- Some light refactoring for readability
- Improve related docstrings and comments
* Add UIWidget._event_pos_relative_to_self * Add UITextInput._event_pos_relative_to_self * Use new method to clean up UITextInput.on_event
* Use self._event_pos_relative_to_self * Restructure it to put the type check * Add comments explaining when / why things are handled
* Use inside_xy in the lower block as well * Improve UITextInput.on_event docstring + comments
|
@DigiDuncan Let me know if the relative position helper seems to belong in |
DragonMoffon
requested changes
Sep 30, 2024
Comment on lines
+181
to
+194
| def _event_pos_relative_to_self(self, mouse_event: UIMouseEvent) -> Vec2 | None: | ||
| """Gets coords relative to bottom left if inside the widget. | ||
|
|
||
| Args: | ||
| mouse_event: Any :py:class:`UIMouseEvent`. | ||
| Returns: | ||
| ``None`` if outside the widget or coords relative to | ||
| the widget's bottom left. | ||
| """ | ||
| pos = mouse_event.pos | ||
| if not self.rect.point_in_rect(pos): | ||
| return None | ||
| return Vec2(pos[0] - self.left, pos[1] - self.bottom) | ||
|
|
There was a problem hiding this comment.
Update to use the new Rect method.
There was a problem hiding this comment.
I didn't update it yet because I want to give it more thought after rereading the UI code and considering the following:
- 3.9 features will be our new minimum
- The new rect method seems to perform more ops
- It may add even more call overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.