Add TorchLog1pVisitor

[kit1980]

Suggest using torch.log1p(x) instead of torch.log(1 + x).
Only a checker for now, probably not worth spending time on a codemod as it's not a very common issue.

I used this to create a PR to botorch pytorch/botorch#2539

[kit1980]

Any ideas how to avoid this ugly duplication of all visitors?

[sbrugman]

Yes, we can automatically pick them up with a registry pattern. Already got something in progress for this.

[sbrugman]

Could we already add Array API examples here? We don't have the capability of automatically detecting them at the moment, but it's good to be explicit about the known false negatives, especially when we can catch them later

import torch

a = torch.randn(5)

print((a + 1).log())
print(a.log1p())

[kit1980]

Added a false negative.

[sbrugman]

Nice catch, LGTM

[sbrugman]

Let's also add pytorch/botorch#2541 / pytorch/botorch#2540 in a follow-up

[kit1980]

Let's also add pytorch/botorch#2541 / pytorch/botorch#2540 in a follow-up

I'll add expm1. Looks like Botorch guys were hinted by my PR about log1p.