Fix: Handle no valid python files in the directory. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zleman1593
changed the title
zleman1593
requested review from
sbrugman,
seemethere,
soulitzer and
kit1980
zleman1593
changed the title
kit1980
reviewed
Nov 11, 2024
kit1980
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run torchfix script on a directory without Python files, it will terminate with an error. This modifies the script to just do nothing in such cases, without terminating with an error.
Testing:
Added test "test_no_python_files"
Without fix the new test fails:
assert 1 == 0
...... raise Exception("Must have at least one job to process!")\nException: Must have at least one job to process!\n').returncode ......