Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSDScratchPadIndicesQueue #2911

Closed
wants to merge 1 commit into from
Closed

Conversation

sryap
Copy link
Contributor

@sryap sryap commented Jul 29, 2024

Differential Revision: D60363607

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 7c3e2a8
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/66b428947a480a00084b7c28
😎 Deploy Preview https://deploy-preview-2911--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from fd9fbb4 to c9e4b20 Compare July 29, 2024 21:05
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from c9e4b20 to d8821af Compare July 29, 2024 21:31
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from d8821af to cede28a Compare July 29, 2024 21:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

@sryap sryap force-pushed the export-D60363607 branch from cede28a to 3e17e9f Compare July 29, 2024 23:17
sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 29, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

@sryap sryap force-pushed the export-D60363607 branch from 3e17e9f to 03caf3f Compare July 31, 2024 01:19
sryap added a commit to sryap/FBGEMM that referenced this pull request Jul 31, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

@sryap sryap force-pushed the export-D60363607 branch from 03caf3f to 29c6577 Compare August 6, 2024 06:44
sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 6, 2024
Summary:
Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from 29c6577 to 5cbbb03 Compare August 7, 2024 19:44
sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 7, 2024
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Differential Revision: D60363607
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 7, 2024
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from 5cbbb03 to f049f5d Compare August 7, 2024 20:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

@sryap sryap force-pushed the export-D60363607 branch from f049f5d to 934d132 Compare August 7, 2024 20:38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 7, 2024
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from 934d132 to d4eda14 Compare August 7, 2024 21:11
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 7, 2024
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from d4eda14 to 1ae085a Compare August 7, 2024 21:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

sryap added a commit to sryap/FBGEMM that referenced this pull request Aug 7, 2024
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@sryap sryap force-pushed the export-D60363607 branch from 1ae085a to bc8ff70 Compare August 7, 2024 21:21
Summary:
X-link: facebookresearch/FBGEMM#41

Pull Request resolved: pytorch#2911

This diff adds `torch.classes.fbgemm.SSDScratchPadIndicesQueue`.  It
is for storing scratch pad indices (conflict missed indices) from
previous iterations. It is used during the L1 cache prefetching step:
instead of fetching the missing indices directly from SSD, TBE will
lookup the scatch pad index queue first to check whether the missing
data is in the scratch pad from the previous iteration.

Note that this class only handles scratch pad indices. Scratch pad
data is stored outside of this class.

Reviewed By: q10

Differential Revision: D60363607
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60363607

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cefcad3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants