Improve Inference UX, add tests, and add inference API docstrings (#2295) #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D61175593 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 14, 2024
…torch#2295) Summary: X-link: facebookresearch/FBGEMM#81 X-link: pytorch/FBGEMM#2988 Pull Request resolved: pytorch#2295 Differential Revision: D61175593
jingsh
approved these changes
Aug 15, 2024
PaulZhang12
force-pushed
the
export-D61175593
branch
from
46a8c8b to
ebe60ee
Compare
PaulZhang12
added a commit
to PaulZhang12/FBGEMM
that referenced
this pull request
Aug 15, 2024
…torch#2988) Summary: X-link: facebookresearch/FBGEMM#81 Pull Request resolved: pytorch#2988 X-link: pytorch/torchrec#2295 Reviewed By: jingsh Differential Revision: D61175593
|
This pull request was exported from Phabricator. Differential Revision: D61175593 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 15, 2024
…torch#2295) Summary: X-link: facebookresearch/FBGEMM#81 X-link: pytorch/FBGEMM#2988 Pull Request resolved: pytorch#2295 Reviewed By: jingsh Differential Revision: D61175593
…torch#2988) Summary: X-link: facebookresearch/FBGEMM#81 Pull Request resolved: pytorch#2988 X-link: pytorch/torchrec#2295 Reviewed By: jingsh Differential Revision: D61175593
PaulZhang12
force-pushed
the
export-D61175593
branch
from
ebe60ee to
e990925
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61175593 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Aug 15, 2024
…torch#2295) Summary: X-link: facebookresearch/FBGEMM#81 X-link: pytorch/FBGEMM#2988 Pull Request resolved: pytorch#2295 Reviewed By: jingsh Differential Revision: D61175593
|
This pull request has been merged in 6599bae. |
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Aug 15, 2024
) Summary: X-link: facebookresearch/FBGEMM#81 X-link: pytorch/FBGEMM#2988 Pull Request resolved: #2295 Reviewed By: jingsh Differential Revision: D61175593 fbshipit-source-id: b565cc01b1c28961cb03b528fd1e951e225b4c24
PaulZhang12
added a commit
to pytorch/torchrec
that referenced
this pull request
Aug 19, 2024
) Summary: X-link: facebookresearch/FBGEMM#81 X-link: pytorch/FBGEMM#2988 Pull Request resolved: #2295 Reviewed By: jingsh Differential Revision: D61175593 fbshipit-source-id: b565cc01b1c28961cb03b528fd1e951e225b4c24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Pull Request resolved: pytorch/torchrec#2295
Differential Revision: D61175593