Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade torch from 2.5.0.dev to 2.6.0.dev in main branch #3165

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

upgrade torch from 2.5.0.dev to 2.6.0.dev in main branch

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanluo-nvidia can you bump the version for C++ too (//cpp/include/macros.h)

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review September 17, 2024 21:05
@github-actions github-actions bot added the component: api [C++] Issues re: C++ API label Sep 19, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Sep 20, 2024
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths and removed component: tests Issues re: Tests labels Sep 21, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/_decompositions.py	2024-09-22 17:33:28.426941+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/_decompositions.py	2024-09-22 17:33:50.978789+00:00
@@ -393,6 +393,10 @@
            if decomp not in torch_disabled_decompositions
        }
        return {**CORE_ATEN_DECOMPOSITIONS_FILTERED, **TORCH_TRT_DECOMPOSITIONS}
    else:
        # changes made here due to torch2.6 changes https://github.com/pytorch/pytorch/pull/135080
-        return {**_decomp_table_to_post_autograd_aten(), **ENABLED_TORCH_DECOMPOSITIONS, **TORCH_TRT_DECOMPOSITIONS}
+        return {
+            **_decomp_table_to_post_autograd_aten(),
+            **ENABLED_TORCH_DECOMPOSITIONS,
+            **TORCH_TRT_DECOMPOSITIONS,
+        }

py/requirements.txt Show resolved Hide resolved
@lanluo-nvidia lanluo-nvidia merged commit a68e52b into main Sep 23, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants