-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade torch from 2.5.0.dev to 2.6.0.dev in main branch #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: build system
Issues re: Build system
component: api [Python]
Issues re: Python API
labels
Sep 17, 2024
narendasan
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lanluo-nvidia can you bump the version for C++ too (//cpp/include/macros.h
)
…rRT into lluo/upgrade_torch_in_main
github-actions
bot
added
component: lowering
Issues re: The lowering / preprocessing passes
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
and removed
component: tests
Issues re: Tests
labels
Sep 21, 2024
HolyWu
reviewed
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/_decompositions.py 2024-09-22 17:33:28.426941+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/lowering/_decompositions.py 2024-09-22 17:33:50.978789+00:00
@@ -393,6 +393,10 @@
if decomp not in torch_disabled_decompositions
}
return {**CORE_ATEN_DECOMPOSITIONS_FILTERED, **TORCH_TRT_DECOMPOSITIONS}
else:
# changes made here due to torch2.6 changes https://github.com/pytorch/pytorch/pull/135080
- return {**_decomp_table_to_post_autograd_aten(), **ENABLED_TORCH_DECOMPOSITIONS, **TORCH_TRT_DECOMPOSITIONS}
+ return {
+ **_decomp_table_to_post_autograd_aten(),
+ **ENABLED_TORCH_DECOMPOSITIONS,
+ **TORCH_TRT_DECOMPOSITIONS,
+ }
peri044
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
component: api [C++]
Issues re: C++ API
component: api [Python]
Issues re: Python API
component: build system
Issues re: Build system
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
component: lowering
Issues re: The lowering / preprocessing passes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade torch from 2.5.0.dev to 2.6.0.dev in main branch
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: