Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed one typo #1954

Closed
wants to merge 1 commit into from
Closed

Conversation

Sarvesh-Kesharwani
Copy link
Contributor

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/pytorch/botorch, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Hi @Sarvesh-Kesharwani!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Sarvesh-Kesharwani
Copy link
Contributor Author

@Balandat
Copy link
Contributor

Thanks for the fix. Could you sign the CLA so that we can merge this in?

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1954 (49a76b1) into main (d346b55) will not change coverage.
The diff coverage is n/a.

❗ Current head 49a76b1 differs from pull request most recent head 0e1d0af. Consider uploading reports for the commit 0e1d0af to get more accurate results

@@           Coverage Diff           @@
##             main    #1954   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         178      178           
  Lines       15744    15744           
=======================================
  Hits        15736    15736           
  Misses          8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 27, 2023
@esantorella esantorella self-requested a review July 27, 2023 14:39
Copy link
Member

@esantorella esantorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Balandat merged this pull request in 93d5866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants