Fix PyTorch version in test-against-stable workflow #2085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@saitcakmak merged this pull request in 11bfb50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the conditional block was always evaluating to true, leading to PyTorch 2.0.1 being used across the board as the minimum version. With this change, all jobs except for Python 3.11 on macOS use PyTorch 1.31.1.
Note: I could not get the expression to work while keeping the
min_torch_version == '1.13.1'check in place, so I removed it. It doesn't have any functional effect as long as we address the TODO when we bump the min version.Old run that used PyTorch 2.0.1 for all jobs: https://github.com/pytorch/botorch/actions/runs/6739329549/job/18320600699
New run that uses correct versions: https://github.com/pytorch/botorch/actions/runs/6774951160/job/18413146849
1.13.1 with ubuntu jobs:
1.13.1 with Py 3.9 on MacOs:
2.0.1 with Py 3.11 on MacOS: