Remove stable Ax from BoTorch CI, add smoke test tutorials to test-against-stable workflow #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
esantorella
approved these changes
Nov 6, 2023
| run_tutorials_stable_w_stable_ax: | ||
| name: Run tutorials without smoke test on min req. versions of PyTorch & GPyTorch and stable Ax | ||
| run_tutorials_stable_smoke_test: | ||
| name: Run tutorials with smoke test on min req. versions of PyTorch & GPyTorch and latest Ax |
There was a problem hiding this comment.
Suggested change
| name: Run tutorials with smoke test on min req. versions of PyTorch & GPyTorch and latest Ax | |
| name: Run tutorials with smoke test on min req. (stable) versions of PyTorch & GPyTorch and latest Ax |
|
@saitcakmak merged this pull request in 6bde5d4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable Ax often lacks changes that would make it compatible with latest BoTorch. As a result, this was creating more noise than the signal it provided. Removing it to clean up signals.
Also adds a smoke-test tutorial run to the workflow, which should help provide faster signals when something fails.
Running in https://github.com/pytorch/botorch/actions/runs/6776353879
(there are a couple pre-existing failures, fixed in #2083)