Update filtered input data type warning type in BoTorchTestCase #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 189 189
Lines 16686 16681 -5
==========================================
- Hits 16682 16677 -5
Misses 4 4 ☔ View full report in Codecov by Sentry. |
Summary: Deprecated since pytorch#1486 Differential Revision: D56799082 Reviewed By: Balandat
Summary: Since pytorch#2304, these warnings use `InputDataWarning`. The current filter does not filter these out: https://github.com/pytorch/botorch/actions/runs/8904363989/job/24453525662 Also audited the test classes to make sure they call `super().setUp()` if they overwrite `setUp`. Differential Revision: D56805187
saitcakmak
force-pushed
the
export-D56805187
branch
from
2352aea
to
f47795b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since #2304, these warnings use
InputDataWarning. The current filter does not filter these out: https://github.com/pytorch/botorch/actions/runs/8904363989/job/24453525662Also audited the test classes to make sure they call
super().setUp()if they overwritesetUp.Differential Revision: D56805187