typing: Use Self from typing_extensions

[eddiebergman]

Motivation

Why wait till 3.11 :) The dependancy of typing_extensions is already present in torch and is a core python development library with the same license as python itself.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I believe this only needs to pass the lint checks. However as it adds a new dependancy (which should be installed already with torch), there could be issues with action runners if installation of dependencies is done in a non-standard manner. However it seems like it should be fine.

Related PRs

• Closes [Style] Use typing_extensions.Self pre-3.11 Python #2487 (issue, not PR)

[facebook-github-bot]

@sdaulton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (d52205a) to head (d6a5c03).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2494   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         193      193           
  Lines       16947    16947           
=======================================
  Hits        16945    16945           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sdaulton]

Looks good to me. Could you put the new import in alphabetical order to resolve the formatting failure? Thanks!

[eddiebergman]

Hi @sdaulton,

Sorry, I was on vacation and then there was a conference I was attending. I've fixed the formatting (I believe) and also merged with the most current main which git marked as a conflict

[facebook-github-bot]

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[eddiebergman]

Noticed one more formatting issue from github actions, fixed and pushed

[facebook-github-bot]

@Balandat merged this pull request in ec2ad88.