fix custom botorch model in ax tutorial #2618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65605144 |
Summary: Update to use SurrogateSpec+ ModelConfigs. Passing arguments (not kwargs) broke with recent changes in Ax Differential Revision: D65605144
sdaulton
force-pushed
the
export-D65605144
branch
from
abc00d4
to
077a199
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65605144 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17368 17368
=======================================
Hits 17366 17366
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 9ae465b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update to use SurrogateSpec+ ModelConfigs. Passing arguments (not kwargs) broke with recent changes in Ax
Differential Revision: D65605144