Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with pytest, not bash #216

Merged
merged 13 commits into from
Aug 31, 2021
Merged

Run tests with pytest, not bash #216

merged 13 commits into from
Aug 31, 2021

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 3, 2021 •
edited
Loading

This will avoid the CI stopping at the first failure, provide much cleaner CI logs, and overall easier/cleaner local testing as well

@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: b664c0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/610906825607650007839938

😎 Browse the preview: https://deploy-preview-216--pytorch-hub-preview.netlify.app

@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: a7fe714

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/6109083e5e6bfe0007dfab3a

😎 Browse the preview: https://deploy-preview-216--pytorch-hub-preview.netlify.app/ecosystem

1 similar comment
@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: a7fe714

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/6109083e5e6bfe0007dfab3a

😎 Browse the preview: https://deploy-preview-216--pytorch-hub-preview.netlify.app/ecosystem

@netlify
Copy link

netlify bot commented Aug 3, 2021 •
edited
Loading

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: 60eb03e

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/612e3a530396c800071f8f4d

😎 Browse the preview: https://deploy-preview-216--pytorch-hub-preview.netlify.app/ecosystem

@NicolasHug NicolasHug mentioned this pull request Aug 3, 2021
Merged
@NicolasHug
Copy link
Member Author

NicolasHug commented Aug 3, 2021 •
edited
Loading

Since we have the same failures on #217, and thus on master, I think this one is actually good to merge.

parmeet
parmeet approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Now we have the summary at the end showing all the models that failed :)

@NicolasHug
Copy link
Member Author

Hm, after looking a bit more, it seems that #217 is failing on 26 files whereas here we're failing on 35 files. For example facebookresearch_semi-supervised-ImageNet1K-models_resnext fails here but not on master or on #217

Let's wait a bit before merging this one. We're working on the HTTP rate limit issue, it will hopefully resolve everything

Until then, we could merge #217

@parmeet
Copy link
Contributor

parmeet commented Aug 3, 2021

Hm, after looking a bit more, it seems that #217 is failing on 26 files whereas here we're failing on 35 files. For example facebookresearch_semi-supervised-ImageNet1K-models_resnext fails here but not on master or on #217

Let's wait a bit before merging this one. We're working on the HTTP rate limit issue, it will hopefully resolve everything

Until then, we could merge #217

sounds good! Do we know what is causing these additional failures?

@NicolasHug
Copy link
Member Author

I think they're the same as #212

@NicolasHug NicolasHug merged commit 45c4ca3 into pytorch:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmeet parmeet parmeet approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasHug @parmeet @malfet @facebook-github-bot