Fixed failing tests for mps device #3143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
vfdev-5
reviewed
Nov 23, 2023
| @@ -22,6 +22,8 @@ def test_no_distrib(capsys): | |||
| assert idist.backend() is None | |||
| if torch.cuda.is_available(): | |||
| assert idist.device().type == "cuda" | |||
| elif torch.backends.mps.is_available(): | |||
There was a problem hiding this comment.
we have to put a guard _torch_version_le_112 here as we have also tests for older pytorch version where mps backend does not exist.
There was a problem hiding this comment.
Also, to run the test, you need to remove @pytest.mark.skipif
vfdev-5
reviewed
Nov 23, 2023
| @@ -43,6 +45,8 @@ def test_no_distrib(capsys): | |||
| assert "ignite.distributed.utils INFO: backend: None" in out[-1] | |||
| if torch.cuda.is_available(): | |||
| assert "ignite.distributed.utils INFO: device: cuda" in out[-1] | |||
| elif torch.backends.mps.is_available(): | |||
vfdev-5
reviewed
Nov 23, 2023
| def forward(self, x, bias=None): | ||
| if bias is None: | ||
| bias = 0.0 | ||
| def forward(self, x): |
vfdev-5
reviewed
Nov 23, 2023
| @@ -69,8 +66,8 @@ def get_first_element(output): | |||
| optimizer = SGD(model.parameters(), 0.1) | |||
|
|
|||
| if trace: | |||
| example_inputs = (torch.randn(1), torch.randn(1)) if with_model_fn else torch.randn(1) | |||
| model = torch.jit.trace(model, example_inputs) | |||
| example_input = torch.randn(1) | |||
There was a problem hiding this comment.
Same here, let's revert this. Probably, you need merge origin/master to your branch.
Also, it is a good practice to work on git branches and not on master (pranavvp16:master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for failing mps tests.