-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosine similarity metric #3203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @kzkadc !
I think we can put this implementation to ignite.metrics
instead of contrib metrics as it does not have any 3rd party dependencies.
Let's also write a test to verify the correctness
Co-authored-by: vfdev <vfdev.5@gmail.com>
@kzkadc thanks for the update. Let's put this implementation to |
@vfdev-5 Thank you for your review! I moved it to |
Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: vfdev <vfdev.5@gmail.com>
@kzkadc if auto code-formatting GH action is bothering you, you can disable it from your fork. https://github.com/pytorch/ignite/actions/workflows/code-style.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @kzkadc !
Hi @kzkadc , sorry, I was too quick to merge this PR which actually has failing xla job: https://github.com/pytorch/ignite/actions/runs/8351321508/job/22859463184 |
Fixes #3202
Description:
Check list: