-
-
Notifications
You must be signed in to change notification settings - Fork 669
Enhance EarlyStopping with mode and min_delta_mode parameters for imp… #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+131
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roved score evaluation
vfdev-5
reviewed
Feb 9, 2026
Contributor
Author
|
oh okay I would do that, why the builds are failing though, is it because I changes the python version requirements in project.toml? |
Collaborator
|
It's due to unmaintained visdom package, #3526 |
…ation based on min_delta_mode
vfdev-5
reviewed
Feb 9, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2026
Thanks @aaishwarymishra for pointing out on python-version update in #3520
aaishwarymishra
commented
Feb 9, 2026
aaishwarymishra
commented
Feb 9, 2026
Contributor
Author
|
done |
vfdev-5
approved these changes
Feb 9, 2026
Collaborator
vfdev-5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the
EarlyStoppinghandler in Ignite, adding support for both minimization and maximization modes, as well as absolute and relative thresholds for improvement. It also updates the documentation, validation logic, and expands test coverage to ensure correctness for the new features.Enhancements to EarlyStopping functionality:
modeparameter toEarlyStopping, allowing users to specify whether to maximize or minimize the score. The logic for improvement now supports both directions. [1] [2] [3]min_deltaandmin_delta_modeto support both absolute and relative changes, with explicit logic for each mode and direction. [1] [2]modeandmin_delta_mode. [1] [2]Documentation updates:
modeparameter and the behavior ofmin_delta_mode, including detailed examples for both maximization and minimization. [1] [2]Testing improvements:
Other changes:
pyproject.tomlto allow Python 3.14.…roved score evaluationFixes #{issue number}
Description:
Check list:
part of #3411