Skip to content

Conversation

@marko-pavlovich
Copy link
Contributor

@marko-pavlovich marko-pavlovich commented Feb 9, 2026

Part of the issue #3481 for the engine/deterministic.py

Description:

-removed unnecessary typing imports
-refactored List to list, and Optional[int] to int | None

-ran tests with python -m pytest tests/ignite/engine/test_deterministic.py -x --tb=line --disable-warnings -q

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Feb 9, 2026
@marko-pavlovich marko-pavlovich deleted the Modernize_type_hints_to_Python_3.10+_in_engine/deterministic.py branch February 9, 2026 12:39
…s_to_Python_3.10+_in_engine/deterministic.py
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@vfdev-5 vfdev-5 enabled auto-merge February 9, 2026 13:13
@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 9, 2026
Merged via the queue into pytorch:master with commit aa128f5 Feb 9, 2026
26 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: engine Engine module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants