Override channel priority on installing. Add check for default channel. #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
atalman
changed the title
Add checkchannel where package is installed test test test test test test test test test test test test Fix lint typo
malfet
approved these changes
Nov 30, 2023
| -c defaults \ | ||
| "${PACKAGE_NAME}" \ | ||
| ${CONSTRAINTS} \ | ||
| --override-channels |
There was a problem hiding this comment.
Suggested change
| --override-channels | |
| --override-channels \ | |
| --strict-channel-priority |
There was a problem hiding this comment.
Ok Thank you let me try it
There was a problem hiding this comment.
Looks like override works better, strict failed to resolve some of the installs:
https://github.com/pytorch/test-infra/actions/runs/7040631634/job/19161895215?pr=4770
huydhn
approved these changes
Nov 30, 2023
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Nov 30, 2023
…l. (pytorch#4770) Forward fix for: pytorch#4766 Related to issue: https://github.com/conda/conda/issues/13374 1. Make sure packages are searched in particular order during install. Use override-channel option when installing packages for smoke test: From Conda documentation: https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages ``` From the command line use --c You may specify multiple channels by passing the argument multiple times. Priority decreases from left to right - the first argument is higher priority than the second. From the command line use --override-channels to only search the specified channel(s), rather than any channels configured in .condarc. ``` 2. Add check for validating that required package is actually installed from required channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward fix for: #4766
Related to issue: conda/conda-libmamba-solver#398
Use override-channel option when installing packages for smoke test:
From Conda documentation:
https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages