[Option 2 Example] Dont land #1721
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option 2 of #1682
In our custom overlap_f_b function we write
run_forward()
andrun_backward()
.run_backward()
is run as a separate thread so that we can have both forward and backward running together side by side. Looks like this:We added hooks before and after expert parallel dispatch and combine to signal boundary points, which now turns into

Now in each of these red blocks, we just need
threading.Barrier(2).wait()
so that the comm and compute are scheduled in lock-step.