Fix grad norm clipping for AutoP and dsv3 model init #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketpurandare
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
stack-info: PR: #2270, branch: sanketpurandare/stack/1
sanketpurandare
force-pushed
the
sanketpurandare/stack/1
branch
from
902c95c to
6d42f9a
Compare
meta-cla
bot
added
the
CLA Signed
xmfan
approved these changes
Jan 22, 2026
xmfan
reviewed
Jan 22, 2026
| # 1. nn.Module.__init__() is already called by _DeepSeekV3Model.__init__ | ||
| # 2. Calling ModelProtocol.__init__ after would reset all module state | ||
| # (nn.Module.__init__ clears _modules, _parameters, etc.) | ||
| _DeepSeekV3Model.__init__(self, model_args) |
Member
There was a problem hiding this comment.
will break when ModelProtocol.init does subclass init things
Contributor
Author
There was a problem hiding this comment.
Do you have a better solution in mind?
Member
There was a problem hiding this comment.
we could use torchtitan as the model repository, instead of autoparallel
Contributor
Author
There was a problem hiding this comment.
That's a good idea, we'll do it after we have tested CP as well in auto parallel since that would alos require local map and is faster to iterate when we have model definition in AutoP
tianyu-l
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix grad norm clipping for AutoP and dsv3 model init