[torchcomms] Simplify ParallelDims to use base class inheritance and mesh views #2334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchcomms CI fails(we fail to close comms because there's no comm in self.parallel_dims.comms) due to the change at #1660 that we remove
So that
self._build_mesh_with_epandself._build_mesh_without_epinTorchCommsParallelDimsis not called.This PR combine them together and just call them under TorchCommsParallelDims.build_mesh, so that TorchCommsParallelDims is built successfully, so that we can finally close the comms.