[SAC] Refactor activation checkpointing to use centralized policy-based approach #2357
+95
−152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous activation checkpointing implementation had each model define its own _op_sac_save_list in its respective parallelize.py file. Manually maintaining the op list risks missing standard compute-intensive ops that PyTorch's get_default_op_list() already provides.
This PR:
get_default_op_listac_config.per_op_sac_force_recompute_mm_shapes_by_fqns