[Bugfix] Fix simple_rl_multiprocess.py to be runnable with recent vLLM version
#2359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We make a handful of QOL changes to make
simple_rl_multiprocess.pywork with recent vLLM. These are:Updating the
.gitignoreto ignore theconverted/andmodels/directories that are added by these scriptspyrefly suppressto getprecommitsignal passingUpdate to
README.mdto add monarch requirementAttentionBackendEnumforwarded in locations needed (similar to [Experimental][rl][vllm compat] Update simple_rl example to work with vLLM nightly #2219)Wiring through
enable_gqasupport in vllm_compat attention - this requires reshaping whenq.shape[1]!=k.shape[1]and using an output tensor explicitly with the proper shapeWith these changes, we are able to run the simple_rl_multiprocess script again
Test Plan
Before (Main)
And after patching with the enum:
After