Replace implementation of xla_torch.sync() to xm.mark_step()
#9086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpvnist
force-pushed
the
sync
branch
3 times, most recently
from
7b082fe to
9c34518
Compare
tengyifei
requested changes
May 6, 2025
tengyifei
requested changes
May 7, 2025
ghpvnist
force-pushed
the
sync
branch
2 times, most recently
from
06eff81 to
a2cb810
Compare
tengyifei
approved these changes
May 8, 2025
qihqi
reviewed
May 9, 2025
qihqi
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch/XLA team recommends using
xla_torch.sync()overxm.mark_step()for newer releases and expect the implementation to be the same, sosyncsimply callsxm.mark_step().#8862