Improve number parsing and handle a few more events #193
Conversation
RealCLanger
force-pushed
the
improve-event-parsing
branch
from
479edfe to
a77e2db
Compare
pytr/event.py
Outdated
| else: | ||
| locales = ("de", "en") | ||
| # Prefer german locale. | ||
| locales = ("de", "en") |
There was a problem hiding this comment.
This will introduce a new issue, sometimes the TR API delivers numbers in American format, this will result in errors such as:
10.002 getting parsed as 10002 instead of 10.002 when parsed by german first.
There was a problem hiding this comment.
ok, can you name specific events where that would happen? As I said, at least in my TR account I did not encounter a problem. But it might be just a coincidence.
There was a problem hiding this comment.
I put some more effort into this and checked all the events in my timeline where en should be preferred before de when parsing numbers. I also added logs/warnings and an option to dump more data that could help developers.
RealCLanger
force-pushed
the
improve-event-parsing
branch
2 times, most recently
from
65f1b99 to
fbd11ba
Compare
RealCLanger
force-pushed
the
improve-event-parsing
branch
from
fbd11ba to
9c608a0
Compare
|
I think this PR is in quite a good shape now. I'll merge it tomorrow, if there's no further comments. |
This tries to address a few things.
First of all I added two additional event types that occured in my depot lately:
trading_savingsplan_executedwhich seems to be something likeSAVINGS_PLAN_EXECUTEDorSAVINGS_PLAN_INVOICE_CREATED. And additionallyTRADE_CORRECTEDwhich is likeTRADE_INVOICE.In order to identify new events in the future I thought it's a good idea to log a warning when unknown events occur. I added code for that.
Furthermore I try to address issue with locales and number parsing, which still seem to exist as per the recent discussion in #141 (#141 (comment)). My idea is to give the german local a general preference before english. With that, at least in my account, going through the whole history, I could not spot regressions. However, if anybody observes something, please let me know.
Generally, most numbers will be parsed correctly because it can be something like
1.234,56- german which will fail to be parsed as english and1,234.56which will fail with the german locale. An issue would now be a situation where you have a full english localized in the range of 1000 - 999999 that could be written like1,000and would now be parsed as 1.0 instead of 1000.0.But as the number format in TR data seems to be wildly mixed it is really hard to predict. Maybe we could change the locale preference for some specific types of events + titles - feedback welcome.