Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Přidání seznamu členů #190

Merged
merged 7 commits into from
Dec 28, 2020
Merged

Přidání seznamu členů #190

merged 7 commits into from
Dec 28, 2020

Conversation

honzajavorek
Copy link
Member

@honzajavorek honzajavorek commented Nov 29, 2020 •
edited
Loading

Fixes #111, supersedes #112, fixes #19

Screenshot_2020-11-29 Pyvec, neziskovka české Python komunity

@honzajavorek honzajavorek mentioned this pull request Nov 29, 2020
Closed
@honzajavorek honzajavorek marked this pull request as ready for review November 29, 2020 16:47
@honzajavorek honzajavorek requested a review from a team November 29, 2020 16:48
encukou
encukou reviewed Dec 28, 2020
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this as I don't have access to the member data, but the code looks OK to me.

pyvecorg/avatars.py Outdated Show resolved Hide resolved
@honzajavorek @encukou
fix if/elif
f1e603d 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@honzajavorek
Copy link
Member Author

Tak to mergnu a kdyžtak opravíme. Koukám, že aktuálně na webu ani ty avatary nefungujou...

image

@honzajavorek honzajavorek merged commit 6b894d1 into master Dec 28, 2020
@honzajavorek honzajavorek deleted the honzajavorek/roster branch December 28, 2020 14:42
@honzajavorek
Copy link
Member Author

sweat

@encukou
Copy link
Member

encukou commented Dec 28, 2020

Funguje to! :)

@honzajavorek
Copy link
Member Author

Zatím 😄 Teda, chtěl jsem říct: Hurá!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zobrazit počet členů spolku Seznam členů
2 participants
@honzajavorek @encukou