Add missing sock.close() to rpc _connect() #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket was not closed if the _connect() function timed out. This lead to an unclosed socket every time a second instance of pyvisa attempted to connect to a device while the first instance of pyvisa still had an open connection. With this fix, the second instance can back off and try again at a later time without reaching an irrecoverable state.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 23.05% 23.04% -0.01%
==========================================
Files 22 22
Lines 3292 3293 +1
Branches 456 456
==========================================
Hits 759 759
Misses 2516 2516
- Partials 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket was not closed if the _connect() function timed out. This lead to an unclosed socket every time a second instance of pyvisa attempted to connect to a device while the first instance of pyvisa still had an open connection.
With this fix, the second instance can back off and try again at a later time without reaching an irrecoverable state.
black . && isort -c . && flake8with no errors