-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple progress bar to simulations #233
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge in a couple of days if nobody else reviews :)
@viljarjf I've just realised you aren't on the contributors list. I think you would go in above Isabel Wood. Similarly if you're happy to update the changelog that would be great :) |
@pc494 Done! |
All tests pass on both windows and ubuntu using 3.8.20 for me. In the test workflow, tqdm is forced to version 4.9 (latest is 4.67) so I tried downgrading, and the tests pass with tqdm>=4.13. Seeing as python 3.6 was officially supported from tqdm 4.11 (i.e. it's getting old), we could consider upgrading tqdm? |
I think we should move the minimumPy version to 3.9, test against versions 3.13 and 3.14. For tqdm I suggest picking a sensible looking 4.x patch from early 2024? |
Description of the change
Adds a simple progress bar for simulations with
SimulationGenerator
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py
.unreleased section in
CHANGELOG.rst
.credits
indiffsims/release_info.py
andin
.zenodo.json
.