+ make defensive copy of CompletableFuture before scheduling clean up

q3769 · Sep 23, 2023 · 4b992e2 · 4b992e2
1 parent 37a9cf4
commit 4b992e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -27,7 +27,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.github.q3769</groupId>
     <artifactId>conseq4j</artifactId>
-    <version>20230922.0.0</version>
+    <version>20230922.0.1</version>
     <packaging>jar</packaging>
     <name>conseq4j</name>
     <description>A Java concurrent API to sequence related tasks while concurring unrelated ones</description>

diff --git a/src/main/java/conseq4j/execute/ConseqExecutor.java b/src/main/java/conseq4j/execute/ConseqExecutor.java
@@ -146,9 +146,10 @@ public <T> CompletableFuture<T> submit(@NonNull Callable<T> task, @NonNull Objec
                 (k, presentTask) -> (presentTask == null) ?
                         CompletableFuture.supplyAsync(() -> call(task), workerExecutorService) :
                         presentTask.handleAsync((r, e) -> call(task), workerExecutorService));
+        CompletableFuture<?> copy = latestTask.thenApply(r -> r);
         latestTask.whenCompleteAsync((r, e) -> activeSequentialTasks.computeIfPresent(sequenceKey,
                 (k, checkedTask) -> checkedTask.isDone() ? null : checkedTask), adminService);
-        return (CompletableFuture<T>) latestTask.thenApply(r -> r);
+        return (CompletableFuture<T>) copy;
     }
 
     @Override