-
-
Notifications
You must be signed in to change notification settings - Fork 17
refactor: split type definition to multiple files, define all framework types inside the Q5
class using build script
#137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
one file for all framework functions and variable declarations, another for the "instance mode" class
My first draft of this was just naively inserting all the type definitions from I tested this change by copying the new All suggestions / change requests welcome. I am not quite sure, for example, if the naming of the type files matches the official terminology, so if you want those to be changed, that's fine. |
I can't merge because All files in Also use tabs instead of spaces in |
Thanks for the review, I'll resolve these next time I'm at my desktop.
That's actually still there, it just references the type files with /// . But yeah,
Good catch, will do.
Yeah, that's either my editor or |
That'd almost work but https://q5js.org/learn/#Q5 Perhaps you could build one typescript file |
That would work, I guess. But maybe it would be less work on the |
9f3dc65
to
982bb0e
Compare
982bb0e
to
cc0e5c8
Compare
@xynydev How's it going on this? |
Fixes: #132