Update slack upload flow v2 #292
Conversation
There was a problem hiding this comment.
Please make sure to rebase the branch
There was a problem hiding this comment.
not fixed, please rebase your branch
...-notifications-api/src/main/java/guru/qa/allure/notifications/clients/slack/SlackClient.java
Show resolved
Hide resolved
(cherry picked from commit 8670931)
|
@valfirst review please |
| try (CloseableHttpClient client = HttpClients.createDefault()) { | ||
| postMessage(client, messageData); | ||
| } catch (IOException e) { | ||
| log.error("Failed to post message to Slack", e); |
There was a problem hiding this comment.
wrap into MessagingException and re-throw it
| slack.getTemplatePath())) | ||
| .asString() | ||
| .getBody(); | ||
| @SneakyThrows |
| postMessage(client, messageData, filePermalink); | ||
|
|
||
| } catch (IOException e) { | ||
| log.error("Failed to post message with file to Slack", e); |
There was a problem hiding this comment.
wrap into MessagingException and re-throw it
| } | ||
|
|
||
| private String getTextData(MessageData messageData) { | ||
| return String.format("channel=%s&text=%s", slack.getChat(), proceedMessageData(messageData)); |
There was a problem hiding this comment.
use UrlEncodedFormEntity instead
| } | ||
|
|
||
| //todo wait until file processing to complete | ||
| Thread.sleep(2000); |
There was a problem hiding this comment.
is there way to check is file processing completed instead of hardcoded wait?
|
@valfirst fix review. |
|
@Phoenix124 please rebase the changes against |
|
@valfirst updated from master |
Phoenix124
changed the title
| HttpUriRequest request = RequestBuilder | ||
| .get("https://slack.com/api/files.getUploadURLExternal") | ||
| .addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + slack.getToken()) | ||
| .addHeader(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.getMimeType()) |
There was a problem hiding this comment.
is this header really needed for GET request?
No description provided.