-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hw 5 1 #53
base: main
Are you sure you want to change the base?
Hw 5 1 #53
Conversation
2 Создание проекта на основе первого урока + добавление логирования 3 Перенос объектов в submodel
# Conflicts: # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/api/SpendApi.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/api/SpendApiClient.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/jupiter/extension/UsersQueueExtension.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/page/EditSpendingPage.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/page/LoginPage.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/test/web/SpendingWebTest.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/jupiter/Category.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/jupiter/CategoryExtension.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/jupiter/TestMethodContextExtension.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/jupiter/meta/WebTest.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/page/FriendsPage.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/page/MainPage.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/page/PeoplePage.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/page/ProfilePage.java # niffler-e-2-e-tests/src/test/java/guru/qa/nifler/page/RegisterPage.java
2 Добавление классов для хранения ошибок и констант
2 Добавление классов для хранения ошибок и констант
HW2 Добавление аннотаций
2 Выполнение Дз ч1
2 Выполнения ДЗ
Выполнения ДЗ номер 3
2 Выполнение ДЗ
1 Выполнения задания по лекции 4.1
2 Выполнение ДЗ
1 Выполнения задания по лекции 4.2
2 Выполнения дз
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добрый вечер,
работа принята, оставила несколько примечаний.
P.S. смотрела только код, относящийся напрямую к дз.
Optional<AuthAuthorityEntity> findById(UUID userId); | ||
List<AuthAuthorityEntity> findAll(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Подушню немного :)
Старайтесь придерживаться единого стиля форматирования. Обычно принята, что между методами есть разрыв строки.
ue.setId(rs.getObject("id", UUID.class)); | ||
ue.setUserId(rs.getObject("user_id", UUID.class)); | ||
ue.setAuthority(AuthorityEnum.valueOf(rs.getString("authority"))); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ue
result.setAccountNonExpired(rs.getBoolean("account_non_expired")); | ||
result.setAccountNonLocked(rs.getBoolean("account_non_locked")); | ||
result.setCredentialsNonExpired(rs.getBoolean("credentials_non_expired")); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return result
ce.setName(rs.getString("name")); | ||
ce.setUsername(rs.getString("username")); | ||
ce.setArchived(rs.getBoolean("archived")); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ce
CategoryEntity category = new CategoryEntity(); | ||
category.setId(rs.getObject("category_id", UUID.class)); | ||
se.setCategory(category); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return se
result.setPhoto(rs.getBytes("photo")); | ||
result.setPhotoSmall(rs.getBytes("photo_small")); | ||
result.setFullname(rs.getString("full_name")); | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return result
1 Выполнения задания по лекции 5.1
2 Выполнения дз