Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved CGI credentials to nf secrets #3

Merged
merged 19 commits into from
Feb 1, 2024

Conversation

HomoPolyethylen
Copy link
Contributor

@HomoPolyethylen HomoPolyethylen commented Jan 26, 2024

CGI credentials used to be pipeline param, moved to nextflow secrets, so that credentials are not open readable.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/variantmtb branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@mapo9 mapo9 self-assigned this Jan 26, 2024
@HomoPolyethylen
Copy link
Contributor Author

nf-core CI / Run pipeline with test data (21.10.3) fails:

Error mesage

Error executing process > 'NFCORE_VARIANTMTB:VARIANTMTB:QUERYNATOR_CIVICAPI (test_sample)'

Caused by:
  Failed to create Conda environment
  command: conda create --mkdir --yes --quiet --prefix /home/runner/work/variantmtb/variantmtb/work/conda/env-8333bfb82ced3d481ee8f58aa4d2aef8 bioconda::querynator=0.4.1
  status : 1
  message:
    PackagesNotFoundError: The following packages are not available from current channels:
    
      - bioconda::querynator==0.4.1
    
    Current channels:
    
      - defaults
      - https://conda.anaconda.org/bioconda

had this issue before, if I remember correctly, adding conda-forge resolved it

Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!
Famke should have a look as well I think

CHANGELOG.md Show resolved Hide resolved
modules/local/querynator/cgiapi.nf Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We just need to fix the CI stuff. Do we know why Python 3.6 is used?

Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Famke.
Niclas, maybe you can add the problems that occured to the issue that already exists with the ToDos
LGTM then 🚀

Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!
LGTM
let's merge

@HomoPolyethylen HomoPolyethylen merged commit 158c5f6 into qbic-pipelines:dev Feb 1, 2024
4 of 5 checks passed
HomoPolyethylen added a commit that referenced this pull request Apr 9, 2024
removed fasta default value, so it can be reassigned by script and ge…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants