Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid code duplication under platform defines #19748

Closed
wants to merge 1 commit into from
Closed

Avoid code duplication under platform defines #19748

wants to merge 1 commit into from

Conversation

Kolcha
Copy link
Contributor

@Kolcha Kolcha commented Oct 22, 2023

found accidentally, the same trick is used in other places in this file

@xavier2k6 xavier2k6 requested a review from a team October 30, 2023 10:59
@glassez
Copy link
Member

glassez commented Oct 30, 2023

I would prefer to see such small duplications. They look more readable, IMO.
@Chocobo1?

@Kolcha
Copy link
Contributor Author

Kolcha commented Nov 4, 2023

not so much value, let's keep as is, closing pull request

@Kolcha Kolcha closed this Nov 4, 2023
@Kolcha Kolcha deleted the cleanup branch November 4, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kolcha @glassez