Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy comment functionality to the torrent list's context menu #19846

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add copy comment functionality to the torrent list's context menu #19846

merged 1 commit into from
Nov 7, 2023

Conversation

thalieht
Copy link
Contributor

@thalieht thalieht commented Nov 1, 2023 •
edited
Loading

  • Didn't know which icon to use so i used the same as the one for "Copy" menu item.
  • Not sure what to do about WeAPI version.
  • In WebUI i suppose it would be desirable to clear the clipboard before the copy in case there is something else there and no selected torrent has a comment but i couldn't figure out how to do that.

Closes #18890.

thalieht
thalieht commented Nov 1, 2023
View reviewed changes
src/gui/transferlistwidget.cpp
torrentComments << torrent->comment();
}

qApp->clipboard()->setText(torrentComments.join(u"\n---------\n"_s));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment can span multiple lines and even contain empty lines. Is something like this acceptable or even desirable to differentiate comments from each other?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use it until someone has a better idea.

@glassez glassez requested a review from a team November 2, 2023 03:58
@glassez glassez added WebUI WebUI-related issues/changes GUI GUI-related issues/changes labels Nov 2, 2023
@glassez glassez mentioned this pull request Nov 4, 2023
Closed
@stalkerok
Copy link
Contributor

Tested 👍
@thalieht, thanks!

@glassez glassez added this to the 5.0 milestone Nov 6, 2023
@glassez glassez merged commit 30d9978 into qbittorrent:master Nov 7, 2023
13 checks passed
@glassez
Copy link
Member

glassez commented Nov 7, 2023

@thalieht
Thank you!

@thalieht thalieht deleted the copy-comments branch November 7, 2023 15:17
@stalkerok
Copy link
Contributor

@glassez, can be backported to 4.6.x?

@glassez
Copy link
Member

glassez commented Nov 7, 2023

@glassez, can be backported to 4.6.x?

To me, it looks trivial enough to be backported without possibly negatively affecting anything else. But @Chocobo1 usually adheres to a stricter policy, so only bugfixes are allowed to be backported. So let's ask him.

@stalkerok
Copy link
Contributor

@Chocobo1, ??

@stalkerok
Copy link
Contributor

@Chocobo1, Is it possible to do a backport of this PR?

@xavier2k6 xavier2k6 mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Add "copy comment" option to context menu
4 participants
@thalieht @stalkerok @glassez @Chocobo1