WebUI: Change filter inputs to type search #22033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing input type from text to search for all search and filter inputs to enable user to easily clear input. This feature is yet to be implemented in Firefox. See tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1654288 Also fix search icon horizontal positioning and minor input box paddings. Closes qbittorrent#15481
thalieht
approved these changes
Dec 20, 2024
Chocobo1
approved these changes
Dec 20, 2024
|
@PatrikElfstrom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing input type from text to search for all search and filter inputs
to enable user to easily clear input.
This feature is yet to be implemented in Firefox.
See tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1654288
Also fix search icon horizontal positioning and minor input box paddings.
Don't know why 12px right padding was added on some inputs in #21464
But I remove that because it didn't really work with the clear button.
Here is a before and after in Firefox, Chrome, and Safari, on MacOS:
Closes #15481