Add "% Selected" column to transfer list #22131
Conversation
glassez
changed the title
src/gui/transferlistmodel.cpp
Outdated
| @@ -194,6 +194,7 @@ QVariant TransferListModel::headerData(const int section, const Qt::Orientation | |||
| case TR_INFOHASH_V2: return tr("Info Hash v2", "i.e: torrent info hash v2"); | |||
| case TR_REANNOUNCE: return tr("Reannounce In", "Indicates the time until next trackers reannounce"); | |||
| case TR_PRIVATE: return tr("Private", "Flags private torrents"); | |||
| case TR_PERCENT_SELECTED: return tr("% Selected", "Percentage of torrent selected"); | |||
There was a problem hiding this comment.
% Selected
Don't know about others but for me, what comes to mind is percentage of files selected not percentage of size.
There was a problem hiding this comment.
I can see where the confusion comes from, but I'm not sure how exactly to call it in order to make it clearer.
Changed it to % Selected Data, but I accept other suggestions that make it clearer.
There was a problem hiding this comment.
I would return “% Selected” or even leave just “%” to minimize the column width as much as possible since there is a tooltip.
There was a problem hiding this comment.
As advised, I've changed the text to the shortest version %.
There was a problem hiding this comment.
Use the tooltip for this column.
There was a problem hiding this comment.
A plain "%" as column header is completely unacceptable IMO.
There was a problem hiding this comment.
In any other case, the column content will always be smaller than the column header, can minimize the column header as much as possible and use a tooltip.
There was a problem hiding this comment.
can minimize the column header as much as possible and use a tooltip.
That will be the case regardless of the header's string length.
Take for example the # (queue column) there are many issues complaining how the torrent's "index" or something like that column is gone or whatever. Who knows how many people actually don't know that it's the queue position.
src/gui/transferlistsortmodel.cpp
Outdated
| @@ -208,6 +208,7 @@ int TransferListSortModel::compare(const QModelIndex &left, const QModelIndex &r | |||
| case TransferListModel::TR_RATIO: | |||
| case TransferListModel::TR_RATIO_LIMIT: | |||
| case TransferListModel::TR_POPULARITY: | |||
| case TransferListModel::TR_PERCENT_SELECTED: | |||
There was a problem hiding this comment.
You should put it at the toLongLong() group instead.
There was a problem hiding this comment.
Or perhaps you should calculate it in floating point instead of integer.
There was a problem hiding this comment.
Changed it so that we .toFloat() for this column before we compare.
| @@ -166,6 +172,7 @@ QVariantMap serialize(const BitTorrent::Torrent &torrent) | |||
| {KEY_TORRENT_COMMENT, torrent.comment()}, | |||
| {KEY_TORRENT_PRIVATE, (torrent.hasMetadata() ? torrent.isPrivate() : QVariant())}, | |||
| {KEY_TORRENT_TOTAL_SIZE, torrent.totalSize()}, | |||
| {KEY_TORRENT_HAS_METADATA, torrent.hasMetadata()} | |||
| {KEY_TORRENT_HAS_METADATA, torrent.hasMetadata()}, | |||
| {KEY_TORRENT_PERCENT_SELECTED, getSelectedPercentage()} | |||
There was a problem hiding this comment.
Furthermore, it seems you shouldn't add this field. The percentage can already be calculated from existing data. Just do the calculation with existing data in WebUI.
There was a problem hiding this comment.
I cannot find an example of a similar column, and my attempts to add a calculated column result in an empty column and non-executing updateTd.
The closest to a calculated column I see is time_active but it is also present in serialize_torrent.cpp & serialize_torrent.h.
If you know a column that does "the calculation with existing data in WebUI" just tell me which and I will try to implement it likewise.
There was a problem hiding this comment.
The percentage can already be calculated from existing data.
I'm not defending the extra field but the same can be said about ETA, popularity and amount_left...
|
Tested. |
Closes #22087.
Description
A new column that displays the % of selected data from a torrent.
Its meant to make it easier to distinguish and manage partial torrents as described in the issue.
UI images
Two partial picture of the UI follow, first is from Desktop app (Linux) second is from WebUI (Linux, Mozilla)
Example use case
You download a few episodes of series or files and want to determine by the first files if its worth downloading the whole torrent. In the presence of multiple torrents it might become bothersome to seek out those partial ones.
With this column you could go in
Completedand order by% Selectedascending, which would put the partial torrents on top. From there on its up to the user.