-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix torrent content checkbox state under certain conditions #22190
Conversation
Set folder as partially checked when it has at least one partially checked child and none unchecked. Closes qbittorrent#22189
Should't it behave as the following?
|
It does... doesn't it? Or did i phrase it too weirdly? I tried to describe the conditions for #22189. |
I didn't have time to look at anything except the PR description. I expected it to describe how qBittorrent behaves after PR is merged. The described behavior looks incorrect, so I have provided my suggestion for correct behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Didn't test.
Judging by code changes it does. |
@thalieht |
Is v5.0.x affected? If yes, then it should be backported. |
Yes. |
@thalieht |
I would stick to the previous arrangement to do backports via single cumulative "backport PR" (whenever possible). |
Backported by #22207. |
Set folder as partially checked when it has at least one partially checked child and none unchecked.
Closes #22189.