Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: improve lint checks #22199

Merged
merged 3 commits into from
Jan 25, 2025
Merged

WebUI: improve lint checks #22199

merged 3 commits into from
Jan 25, 2025

Conversation

Chocobo1
Copy link
Member

  • WebUI: enable cache for lint checks
    Also, WebUI gets its own .gitignore file.
  • WebUI: migrate stylelint config file format
    From https://stylelint.io/user-guide/configure :

    Stylelint currently supports other configuration locations and formats, but we may remove these
    in the future:
    ...
    .stylelintrc.json file

  • WebUI: revise lint rules for css
    Some rules are already covered by other tools, so remove them.

Also, WebUI gets its own .gitignore file.
From https://stylelint.io/user-guide/configure :
>Stylelint currently supports other configuration locations and formats, but we may remove these
>in the future:
>...
>.stylelintrc.json file
@Chocobo1 Chocobo1 added the WebUI WebUI-related issues/changes label Jan 24, 2025
@Chocobo1 Chocobo1 added this to the 5.1 milestone Jan 24, 2025
@Chocobo1 Chocobo1 requested a review from a team January 24, 2025 14:29
Some rules are already covered by other tools, so remove them.
@Chocobo1 Chocobo1 merged commit e2341f5 into qbittorrent:master Jan 25, 2025
14 checks passed
@Chocobo1 Chocobo1 deleted the webui_eslint branch January 25, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants