Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor notification protocols #2269

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Nov 11, 2024

Referenced issues

Description of the Change

  • peer count metric and telemetry count "/announce" streams, not connections.
  • protocols are independent.
    • but "/announce" protocol controls "/grandpa" and "/transaction" protocols.
    • authority discovery controls "/validation" protocol.
  • protocol error doesn't close connection to peer, only that protocol stream.
  • protocols decide when to open streams.
  • "/collation" and "/validation" protocols handle ViewUpdate messages, delegating other messages to observer.

Possible Drawbacks

  • check peer reputation before connecting (how can peer reputation grow if there are no streams to raise reputation?)

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant