Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny refactor at strobe.hpp #2384

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tiny refactor at strobe.hpp #2384

wants to merge 4 commits into from

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Feb 20, 2025

Description of the Change

CLang Tidy doesn't like some places here, and it seems like there is actually a way to rewrite them to be a bit simpler and not involving unsafe operations.

Possible Drawbacks

None expected.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm requested review from turuslan and iceseer February 21, 2025 13:36
@Harrm Harrm marked this pull request as ready for review February 21, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants