-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics of implicit, explicit and missed parachain votes #2385
base: master
Are you sure you want to change the base?
Conversation
struct CleanupGuard { | ||
std::function<void()> cleanup; | ||
~CleanupGuard() { | ||
cleanup(); | ||
} | ||
} cleanup_guard{[this, &block_hash] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto guard = std::unique_ptr<void, std::function<void(void*)>>(
(void*)1,
[&](void*) {
state_by_relay_parent_to_check_.erase(block_hash);
}
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
const auto availability_cores_res = | ||
parachain_host_->availability_cores(block_hash); | ||
if (not availability_cores_res) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it->availability_cores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
5c57799
to
44d89fb
Compare
Referenced issues
Description of the Change
Possible Drawbacks
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: