Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics of implicit, explicit and missed parachain votes #2385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ErakhtinB
Copy link
Contributor

Referenced issues

Description of the Change

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@ErakhtinB ErakhtinB requested review from kamilsa and iceseer February 20, 2025 15:54
Comment on lines 3390 to 3395
struct CleanupGuard {
std::function<void()> cleanup;
~CleanupGuard() {
cleanup();
}
} cleanup_guard{[this, &block_hash] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        auto guard = std::unique_ptr<void, std::function<void(void*)>>(
            (void*)1,
            [&](void*) {
                state_by_relay_parent_to_check_.erase(block_hash);
            }
        );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 3433 to 3435
const auto availability_cores_res =
parachain_host_->availability_cores(block_hash);
if (not availability_cores_res) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it->availability_cores

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ErakhtinB ErakhtinB force-pushed the feature/missing_votes_metric branch from 5c57799 to 44d89fb Compare February 21, 2025 08:28
@ErakhtinB ErakhtinB requested a review from iceseer February 21, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants